Skip to content

Commit

Permalink
Fixing: mount_gcsfuse not respecting bool values when passed to bool …
Browse files Browse the repository at this point in the history
…flags e.g. enable_storage_client_library (#1017)

* fixing value in flag while mounting

* fixing value in flag while mounting

* fixing comments
  • Loading branch information
Tulsishah committed Mar 20, 2023
1 parent 6eb81bb commit 6dc99f6
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tools/mount_gcsfuse/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@ func makeGcsfuseArgs(
"enable_storage_client_library",
"reuse_token_from_url",
"enable_nonexistent_type_cache":
args = append(args, "--"+strings.Replace(name, "_", "-", -1))
if value == "" {
value = "true"
}
args = append(args, "--"+strings.Replace(name, "_", "-", -1)+"="+value)

// Special case: support mount-like formatting for gcsfuse string flags.
case "dir_mode",
Expand Down

0 comments on commit 6dc99f6

Please sign in to comment.