Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for shared VPC host project in the project-factory module. #2271

Closed
wants to merge 4 commits into from
Closed

Add support for shared VPC host project in the project-factory module. #2271

wants to merge 4 commits into from

Conversation

miromichalicka
Copy link
Contributor

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@ludoo
Copy link
Collaborator

ludoo commented May 13, 2024

Thank you, very clean PR :)

ludoo
ludoo reviewed May 13, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an example test in the module's README?

@miromichalicka
Copy link
Contributor Author

Certainly, I'll work on tests later this week

@ludoo ludoo mentioned this pull request May 22, 2024
Merged
@ludoo
Copy link
Collaborator

ludoo commented May 22, 2024

Superseded by #2300

@ludoo ludoo closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo left review comments

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miromichalicka @ludoo