Add WP version comparison script #68
Conversation
There was a problem hiding this comment.
Thanks @swissspidy, this looks great overall! A few minor comments. I wasn't able to complete the process locally due to an error.
| "homepage": "https://github.com/swissspidy/compare-wp-performance#readme", | ||
| "type": "module", | ||
| "devDependencies": { | ||
| "@wordpress/env": "^8.4.0", |
There was a problem hiding this comment.
Couldn't we alternatively use an older version that doesn't have the bug and thus doesn't require the patch and extra package.json workaround?
There was a problem hiding this comment.
I will need to check what‘s possible / where the bug was introduced and if there are features we can live without or not.
There was a problem hiding this comment.
The bug has since been resolved, so we can use a newer version without a patch, but it still requires 2 package.json files. Or we leverage a global install.
|
@swissspidy I realize this somehow fell off the radar, but was wondering whether we could pick it up again. I think it's close, could you follow up on #68 (comment) and see whether there are any new changes in your repo that should be ported into this PR when you get a chance? |
|
Yeah I'll need to revisit this and merge in the latest changes. But holding off a bit now because it's not urgent (for 6.4 we can still use the existing repo) and there might be significant changes needed when tackling all the variance issues. |
Ports over the GitHub action and the manual Bash script from https://github.com/swissspidy/compare-wp-performance
The individual
package.jsonfiles are unfortunately necessary right now because of WordPress/gutenberg#51419