Add WP Profiler mu-plugin #42
Conversation
There was a problem hiding this comment.
@joemcgill Thank you, I left some feedback. Overall it looks good, though I wonder whether we could work towards having a profiling environment in this repository (not necessarily all in this one PR) rather than only the wp-profiler plugin.
| "WP_DEBUG_DISPLAY": false, | ||
| "SCRIPT_DEBUG": false | ||
| } | ||
| } |
There was a problem hiding this comment.
Having this file here seems a bit out of scope to me as it's for the environment, and the plugin folder itself does not make that environment work.
I think it would be great to implement a simple wp-env configuration in this repository for XHProf so that it's standalone. Of course for XHProf that requires us to first merge your PR WordPress/gutenberg#48147.
My suggestion would be to, instead of a general plugins folder and this plugin, add a folder like wp-profiling-env which includes a basic package.json with the necessary dependencies and scripts to run wp-env, and then an mu-plugins folder with the wp-profiler plugin you have here, as that is most useful as part of that environment.
WDYT? We could of course split that work apart, since right now @wordpress/env does not yet support the necessary XHProf work, but I think eventually this would be a better outcome, have a standalone solution in here rather than only the MU plugin and require the rest to be set up manually.
| @@ -0,0 +1,34 @@ | |||
| <?php | |||
| require __DIR__ . '/vendor/autoload.php'; | |||
There was a problem hiding this comment.
Nit-pick? Should we have a simple plugin header here?
| } catch (Exception $e){ | ||
| // throw away or log error about profiling instantiation failure | ||
| error_log($e->getMessage()); | ||
| } |
There was a problem hiding this comment.
Nit-pick: This file doesn't follow WP coding standards (mostly indentation and spacing-wise).
This adds an example mu-plugin that can be used for configuring a WordPress environment set up using the
wp-envpackage with XHProf support (related PR).