Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update UI/UX of components #679

Merged
merged 12 commits into from
May 23, 2024
Merged

Fix: Update UI/UX of components #679

merged 12 commits into from
May 23, 2024

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented May 17, 2024

Description

This PR updates few items

  • In the dark mode, the “i” icon not visible properly for undermined cookies.
  • Add a hover state for the known breakages. The accordion menu doesn’t have a hover state.
  • Upon keyboard navigation to the extension, pressing the Enter key should trigger the collapse/expand functionality of the section.
  • Truncate the table cell's value if the content is bigger than the column size.

Relevant Technical Choices

Testing Instructions

  • Open the Privacy Sandbox panel and navigate to the Cookie landing page.
  • Find the known breakages section and hover over the accordion.
  • The hover state will change the bg color.
  • Now navigate to the cookie table and enable the mapping column.
  • You'll find an info icon with Undetermined cookies visible in dark mode.
  • Now try resizing some columns, you'll see column values bigger than column size will be truncated.
  • Now click on the cookies sidebar title, and try pressing the Enter or Space key.
  • It should toggle the state of the sidebar to open or close.

Additional Information:

Screenshot/Screencast

Screen.Recording.2024-05-17.at.12.51.04.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mayan-000 mayan-000 self-assigned this May 20, 2024
@mayan-000 mayan-000 marked this pull request as ready for review May 20, 2024 04:58
Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed added this to the v1.0.0 milestone May 23, 2024
@mohdsayed mohdsayed merged commit 48c6580 into develop May 23, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/ui-ux-components branch May 23, 2024 05:50
@fellyph
Copy link
Collaborator

fellyph commented Jun 6, 2024

@mayan-000, the item:

Now click on the cookies sidebar title, and try pressing the Enter or Space key.

Can be associated with issue #678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants