-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add README for bookmarks and page-redder samples #1101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I left a few comments, otherwise passing to @jpmedley for review.
Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your help with this. Editing this took a fraction of the time it would have taken for us to write these. I have a few nits.
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Thanks, next time will do better! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two final nits, let me know when those are resolved and we can merge!
Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
#798