Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README for bookmarks and page-redder samples #1101

Merged
merged 14 commits into from
Feb 27, 2024

Conversation

Pask00
Copy link
Contributor

@Pask00 Pask00 commented Feb 22, 2024

@Pask00 Pask00 marked this pull request as ready for review February 22, 2024 14:52
Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I left a few comments, otherwise passing to @jpmedley for review.

functional-samples/sample.bookmarks/README.md Outdated Show resolved Hide resolved
functional-samples/sample.page-redder/README.md Outdated Show resolved Hide resolved
functional-samples/sample.page-redder/README.md Outdated Show resolved Hide resolved
functional-samples/sample.page-redder/README.md Outdated Show resolved Hide resolved
Pask00 and others added 4 commits February 23, 2024 15:32
Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
Copy link
Contributor

@jpmedley jpmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help with this. Editing this took a fraction of the time it would have taken for us to write these. I have a few nits.

functional-samples/sample.bookmarks/README.md Outdated Show resolved Hide resolved
functional-samples/sample.bookmarks/README.md Outdated Show resolved Hide resolved
functional-samples/sample.bookmarks/README.md Outdated Show resolved Hide resolved
functional-samples/sample.bookmarks/README.md Outdated Show resolved Hide resolved
functional-samples/sample.page-redder/README.md Outdated Show resolved Hide resolved
functional-samples/sample.page-redder/README.md Outdated Show resolved Hide resolved
Pask00 and others added 6 commits February 23, 2024 18:21
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
@Pask00
Copy link
Contributor Author

Pask00 commented Feb 23, 2024

Thank you for your help with this. Editing this took a fraction of the time it would have taken for us to write these. I have a few nits.

Thanks, next time will do better!

Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two final nits, let me know when those are resolved and we can merge!

functional-samples/sample.bookmarks/README.md Outdated Show resolved Hide resolved
functional-samples/sample.page-redder/README.md Outdated Show resolved Hide resolved
Pask00 and others added 2 commits February 27, 2024 18:40
Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
Co-authored-by: Oliver Dunk <oliver@oliverdunk.com>
Copy link
Member

@oliverdunk oliverdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@oliverdunk oliverdunk merged commit c2f53bd into GoogleChrome:main Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants