Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new season type "Year to date" #4439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thejockl
Copy link
Contributor

This PR adds a new semi dynamic season type "Year to date". This helps comparing progress for same timeranges of different years.
It re-uses the start of class Season and grows automatically by using the current day/month as end.
All other season-types should remain as is.

  • Examples (Today: 25.01.2024)
    • Start (configured): 01.01.2023 => End (automatic): 25.01.2023
    • Start (configured): 01.01.2019 => End (automatic): 25.01.2019
    • Start (configured): 01.06.2021 => End (automatic): 25.01.2022

@amtriathlon
Copy link
Member

amtriathlon commented May 7, 2024

Hi Joachim, I think this is too specific to your way of analyzing your data, likely useful to have in your fork, but I am not sure we should merge it.
OTOH, I think a general way to add a Date Range for analysis purposes (other than Season/Phase) exposing the relative and absolute options for start, stop, duration, etc. supported by Season class would be a great addition.

@thejockl
Copy link
Contributor Author

thejockl commented May 7, 2024

Hi @amtriathlon, let me think about your proposal, how this configuration could look like and how to use it. If I have a good idea I will come back to you. BTW, do you prepare the dev-list or a issue for such discussions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants