Train View: Improved the selection of workouts #4400
Conversation
Just a few changes from RC4: - Updated German, Italian and Spanish translations - Better contrast in Athlete Tabs when using dark colors - Better contrast for selected items in Trends/Train sidebar when using dark colors - Clarify texts in Relative Wattage Workout Creator [Publish Binaries]
|
When its ready for commit let me know and will review with a view to pull |
|
All issues I gathered from the users-list are resolved, so I would be happy if you could start the review |
…thub.com/thejockl/GoldenCheetah into 411-feature-request-favorite-workouts-v2
…thub.com/thejockl/GoldenCheetah into thejockl-411-feature-request-favorite-workouts-v2
To use ErgFileBase interfase
|
Hi Joachim, I fixed a conflict due to a merged PR from another contributor and added a little fix for Qt6 compatibility, current conflict is with your own PR, so you will have a better idea about how to fix it. |
|
Hi Ale, happy to see you looking into this PR! I just merged master into this branch, resolving all conflicts. The reason for the *Base-classes (I honestly dislike the name but couldn't come up with something better) is that this helped me developing most of the code in a small testdriver outside Golden Cheetah, giving the following benefits:
By that I had way faster turnaround times, and could better concentrate on the features. |
|
As I experienced a crash related to auto completion when running with Qt6, please wait for a fix before further proceeding |
|
The crash has been fixed |
|
This is a very nice feature, Joaquim, thank you very much! We will need to update the wiki for v3.7 in two places: https://github.com/GoldenCheetah/GoldenCheetah/wiki/UG_Side-Bar_Train-view and https://github.com/GoldenCheetah/GoldenCheetah/wiki/UG_Special-Topics_Workouts%2C-Media-and-VideoSync-Library |
|
Hi @amtriathlon, thanks so much for taking care and merging, I highly appreciate all your efforts! I will look into the Wiki and come up with proposals, probably on the dev-list |
2ac2cd6 Batch Processing addition metadata update (#4399) 9647975 Fix isSpecial(internalName) in SpecialFields e41e6b6 Fit: Add FIELD_87 for record (cycle_length16) fix #4489 c088aaf Fixes the background colour of the group by sub menu (#4492) 06a6dbe Fix copy paste error preventing macOS build 5e3db39 Add delete button to manage filters (#4493) 77df5b3 Train View: Improved the selection of workouts (#4400) cfb8c2f Manage Perspectives - perspectives list cosmetics f1bb83f Update Images default chart 562ef17 Update Spanish translation (#4487) 57c11e0 Remove Ctrl+A shortcut for Add Cloud Account cf2e8d8 Enable translation of Save Changes in SaveExitDialog 1b49890 Update German Translation f97770f GC CSV Export - rcad instead of cad for runs 7a11a6a Initializing AllPlot::isPanning to false (#4482) 76dedfb Fix Average Speed aggregation 6299374 Images chart update on image drop and import fdb6d17 Python Web Chart - Don't accept drops 68ad048 Update Images Python chart in default layout 2d8bdd7 FitRideFile - Decode GAP extra field in m/s 5073ba8 Add Images chart to default layout c693ed6 FitRideFile - Extra fields 136, 143 and 144 4f5a0eb CP Chart - show/hide interval settings based on model and fitting selection (#4382) 0b144cc Train View: Coloring by powerzones in ErgFilePlot (#4479) 02835e3 Added support for old Daum devices before 2001 (#4303) 71c72d6 Changed the standard colors for compare-mode (#4478) 118eafe FitRideFile : A devApp can replace another with same local id 1241c0a Use elapsed time for session (instead of timestamp) fix #4474 a1a76fb WorkoutWizard - Don't save and close on Cancel 64c7ce3 Improved search/filter box drop down menu icon (#4470) [publish binaries]
This PR tries to provide a solution for #411
It introduces a new schema for the TrainDB, filters for workouts and an info-widget in the TrainSideBar. Workouts can be rated and tagged.
The filter works on selected metrics of the workout as well as the description and all assigned tags.
As soon as the zones / CP of an athlete change, the TrainDB is automatically updated.
A manager to add / remove tags was added to the Train settings.
Additionally the change includes refactorings to improve type safety (converted some enums to C++11 enum class) and Extracted pure data baseclasses from ErgFile and VideoSyncFile to achieve faster turnaround times by developing outside GoldenCheetah.
Example for a filter: "duration 1:00..1:15, variability 1.1..1.2, dominantzone z4, stress 80.., rating 3..4"
This PR is the replacement for #4398 after cleaning up the commit-history and realizing Marcs first comments:
Additional remarks: