Addition of CoreTemp sensor support #4207
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amtriathlon
reviewed
Apr 16, 2022
src/FileIO/JsonRideFile.y
Outdated
| @@ -105,6 +105,8 @@ static QString protect(const QString string) | |||
| #define scanner jc->scanner | |||
|
|
|||
| %} | |||
| // generated by the scanner | |||
| %define api.header.include {"JsonRideFile_yacc.h"} | |||
There was a problem hiding this comment.
This change breaks ci builds since it requires a newer bison version
There was a problem hiding this comment.
Apologies. No idea what made that change, removed.
|
Spotted a bug while fixing the CI issue, tidied the change. 😄 |
|
If you want to edit the data remember to update RideEditor::insColumn() and RideEditor::whatColumns() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds ANT+ support for CoreTemp body sensors.
As discussed on #4121 this is now updated to use the XDATA fields rather than changing the saved json.
If there is core temperature data then it uses that for "tcore" data instead of using the estimated calculation.