Crypto aead #31
Merged
Crypto aead #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, I'm currently looking into these PRs! |
CheckSizeInRange now has a []byte argument CheckIntInRange has an Int argument
Includes a significant refactor: - Return error instead of integer - Replace getter functions with constants - Move prepared encryption to cipher.AEAD compatible structure - Add tests
The key and nonce size are now given as an array pointer to make more clear that the key and nonce size are fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new wrapping of
crypto_aeadin a new tree, as discussed in #25.crypto_aeadis split into five packages:crypto/aeadprovides anAEADinterface, which is an extended version of golang'scrypo/cipher.AEAD. This interface is implemented for AES256CGM.crypto/aead/aes256gcmimplements the rest ofcrypto_aead_aes256gcm.crypto/aead/chacha20poly1305implementscrypto_aead_chacha20poly1305.crypto/aead/chacha20poly1305ietfimplementscrypto_aead_chacha20poly1305_ietf.crypto/aead/xchacha20poly1305ietfimplementscrypto_aead_xchacha20poly1305_ietf.All code includes tests with 100% coverage and is linted with
golint.The pull request includes some extension of the support functions, for which I could create a separate pull request if so desired.