Add unit tests #35
Add unit tests #35
Conversation
- files created on update() - no errors when removing source photo - hash dropped from album.yml when removing source photo - clean removes all output files
|
Gertjan, given this excellent idea of adding more tests I've held off on adding anything more PRs or editing. Let me know how you'd like me to proceed. I have almost completed my goal of having HPS work straight from photo management software to website on my own fork. In the process I have had to revisit #29 because I ran into memory issues again. This is something that unittest already pointed out to me when I developed #36. In short I replaced As a milestone, HPS sucessfully generated a hugo website with over 1200 photos in nested directories. Largest single album was 120 photos. I'll be happy to submit/amend integrated or separate PRs against any branch as per your directions. If you'd like to discuss on email or whatsapp you can find me at sebastiaan.lampo + google's email domain. We kunnen de conversatie ook in het Nederlands voeren. |
|
Thanks for your message. I've spent some time on the unit test PR this weekend, but haven't finished it yet. I hope to integrate your other work in due course but working on this project is not a major priority for me at the moment, as you'll hopefully understand. It's great to hear though that you've managed to use HPS successfully on such a large gallery! I'll take your comment on the memory issues into account, thanks for that suggestion. To be continued! |
|
Totally understand, no rush. In the meantime I'll progress on my fork and make it as robust as possible and be ready to format the PRs however is easiest for you. |
|
Sounds like a great plan, thanks for understanding! |
This may be a coding style issue, but I generally don't think these are needed as tests/ is not a module.
|
Hi @sebastiaan-lampo, I think I'm done adding unit tests for now. Do you have any comments on this that I should be aware of before merging? Thanks! |
|
Sorry Gertjan, life took over with a need to find a new home in the next two months. I'll have a look at the new tests and see what others are needed for my additional features. |
|
No worries Sebastiaan, there's no rush. I think most of my changes are minor, so it shouldn't be too much trouble to rebase/merge master into your branches. If there's anything that's unclear, please let me know. |
This PR aims to add some unit tests to this program. It's been quite some time since I've actually worked on this and I want to make sure it's robust before we start adding in the suggestions in #31 and #32.