Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalizing the configuration of GitFlow and GitHubFlow workflow and align with the Mainline version strategy #4020

Conversation

HHobeck
Copy link
Contributor

@HHobeck HHobeck commented May 10, 2024

Finalizing the configuration of GitFlow and GitHubFlow workflow and align with the Mainline version strategy

Description

Do minor changes and refactoring of code

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@HHobeck HHobeck requested a review from asbjornu May 10, 2024 11:24
@HHobeck HHobeck force-pushed the feature/align-trunk-based-version-strategy-with-git-flow branch from 251ed90 to 7766333 Compare May 10, 2024 12:31
@HHobeck
Copy link
Contributor Author

HHobeck commented May 12, 2024

I have done a supplement to the previous PR because of some minor changes. Please review it and give me feedback @asbjornu

@arturcic
Copy link
Member

arturcic commented May 12, 2024

@HHobeck before merging this one we need to fix the CI on main branch

@HHobeck
Copy link
Contributor Author

HHobeck commented May 12, 2024

@HHobeck before merging this one we need to fix the CI on main branch

Yes I agree. Can you help me to fix this? I see the following error:

Error: Assert.Contains() Failure: Sub-string not found
String:    "6.0.0-PullRequest4020.1488"
Not found: "6.0.0-PullRequest4020.3535"

@HHobeck
Copy link
Contributor Author

HHobeck commented May 14, 2024

@HHobeck before merging this one we need to fix the CI on main branch

Yes I agree. Can you help me to fix this? I see the following error:

Error: Assert.Contains() Failure: Sub-string not found
String:    "6.0.0-PullRequest4020.1488"
Not found: "6.0.0-PullRequest4020.3535"

Maybe it has something to do with the following fix:

@HHobeck
Copy link
Contributor Author

HHobeck commented May 21, 2024

I think this PR can be merged. Do you have any suggestion for finalization?

@arturcic
Copy link
Member

I think this PR can be merged. Do you have any suggestion for finalization?

Nope, we need first to fix the main build before merging this one

@arturcic
Copy link
Member

@HHobeck I sent you the details I found while investigating the build error

@HHobeck HHobeck force-pushed the feature/align-trunk-based-version-strategy-with-git-flow branch from 6d0ecd0 to 98b212b Compare May 22, 2024 08:34
@arturcic arturcic merged commit 4f8d583 into GitTools:main May 22, 2024
71 of 113 checks passed
Copy link
Contributor

mergify bot commented May 22, 2024

Thank you @HHobeck for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants