Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#578) Bump Octokit to 10.0.0 to fix oversized ints #579

Merged
merged 2 commits into from Mar 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GitReleaseManager.Cli/GitReleaseManager.Cli.csproj
Expand Up @@ -23,7 +23,7 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Octokit" Version="9.0.0" />
<PackageReference Include="Octokit" Version="10.0.0" />
<PackageReference Include="Serilog.Sinks.Console" Version="4.1.0" />
<PackageReference Include="Serilog.Sinks.Debug" Version="2.0.0" PrivateAssets="All" />
<PackageReference Include="Serilog.Sinks.File" Version="5.0.0" />
Expand Down
Expand Up @@ -26,7 +26,7 @@
<PackageReference Include="NSubstitute" Version="5.1.0" />
<PackageReference Include="NUnit" Version="3.14.0" />
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
<PackageReference Include="Octokit" Version="9.0.0" />
<PackageReference Include="Octokit" Version="10.0.0" />
<PackageReference Include="Shouldly" Version="4.2.1" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion src/GitReleaseManager.Core/GitReleaseManager.Core.csproj
Expand Up @@ -24,7 +24,7 @@
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="NGitLab" Version="6.39.0" />
<PackageReference Include="Octokit" Version="9.0.0" />
<PackageReference Include="Octokit" Version="10.0.0" />
<PackageReference Include="Scriban" Version="5.9.0" />
<PackageReference Include="seriloganalyzer" Version="0.15.0" />
<PackageReference Include="YamlDotNet" Version="13.7.1" />
Expand Down
2 changes: 1 addition & 1 deletion src/GitReleaseManager.Core/Model/Issue.cs
Expand Up @@ -6,11 +6,11 @@
{
public string Title { get; set; }

public int InternalNumber { get; set; }
public long InternalNumber { get; set; }

public int PublicNumber { get; set; }

public string HtmlUrl { get; set; }

Check warning on line 13 in src/GitReleaseManager.Core/Model/Issue.cs

View workflow job for this annotation

GitHub Actions / build (windows-2022)

Change the type of property 'Issue.HtmlUrl' from 'string' to 'System.Uri' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1056)

public IReadOnlyList<Label> Labels { get; set; }

Expand Down
2 changes: 1 addition & 1 deletion src/GitReleaseManager.Tests/GitReleaseManager.Tests.csproj
Expand Up @@ -26,6 +26,6 @@
<PackageReference Include="NSubstitute" Version="5.1.0" />
<PackageReference Include="NUnit" Version="3.14.0" />
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
<PackageReference Include="Octokit" Version="9.0.0" />
<PackageReference Include="Octokit" Version="10.0.0" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion src/GitReleaseManager.Tool/GitReleaseManager.Tool.csproj
Expand Up @@ -39,7 +39,7 @@
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="NGitLab" Version="6.39.0" />
<PackageReference Include="Octokit" Version="9.0.0" />
<PackageReference Include="Octokit" Version="10.0.0" />
<PackageReference Include="Serilog.Sinks.Console" Version="4.1.0" />
<PackageReference Include="Serilog.Sinks.Debug" Version="2.0.0" PrivateAssets="All" />
<PackageReference Include="Serilog.Sinks.File" Version="5.0.0" />
Expand Down