Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging fixes #831

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Logging fixes #831

wants to merge 4 commits into from

Conversation

agateau-gg
Copy link
Collaborator

This small PR make a bunch of small logging fixes, mainly for secret scan ci but not only:

  • Information reported when called with --verbose is now also logged, so using --debug without using --verbose does not end up with less information.
  • When called with --debug, secret scan ci now also logs the list of commits to scan.
  • Fix a case where we were using the root logger instead of the logger defined in the module

Copy link
Contributor

@Paul-GitGuardian Paul-GitGuardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Maybe log_vars should be moved to an higher level? I think it could be used in previous_commit.py too

@agateau-gg
Copy link
Collaborator Author

Nice! Maybe log_vars should be moved to an higher level? I think it could be used in previous_commit.py too

Good idea, going to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants