chore(wording): # Reword credits to quotas for clarity #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agateau-gg
requested changes
Oct 18, 2023
| @@ -20,7 +20,7 @@ def quota_cmd( | |||
| **kwargs: Any, | |||
| ) -> int: | |||
| """ | |||
| Get the number of remaining credits for today. | |||
| Get the remaining quotas for today. | |||
There was a problem hiding this comment.
I don't know if "credits" was the correct word, but I believe "quotas" is not the correct one here. A quota is a limit on something. The only reason it would be plural if is you have several different limits (a soft-limit and a hard-limit for example).
Maybe "API calls" is what we want here, just like in ggshield quota?
There was a problem hiding this comment.
It may be more complex but what do you guys think of "consumption units" ?
There was a problem hiding this comment.
Sounds a bit complex indeed. I thought it would make sense to sync this with the dashboard, but I can't see any mention to this there. Maybe I haven't been looking in the right place?
| @@ -17,7 +17,7 @@ | |||
| @click.pass_context | |||
| def quota_cmd(ctx: click.Context, **kwargs: Any) -> int: | |||
| """ | |||
| Show the remaining quota of API calls available for the entire workspace. | |||
| Show the remaining quotas of API calls available for the entire workspace. | |||
There was a problem hiding this comment.
Suggested change
| Show the remaining quotas of API calls available for the entire workspace. | |
| Show the remaining number of API calls available for the entire workspace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid mixing credits and quota.
Credits are one prefix call, on the landing page for instance.
A quota is one quota as counted by the API.