GHA: run ci only on 'main' branch pushes #731
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agateau-gg
requested changes
Aug 30, 2023
| @@ -10,7 +10,7 @@ on: | |||
| pull_request: | |||
| push: | |||
| branches: | |||
| - '*' | |||
| - 'main' | |||
There was a problem hiding this comment.
It should also be run on hotfix branches, so I suggest adding something like - '[0-9]+.[0-9]+.x'. Make sure you test this on a sandbox repo though, my suggestion might be wrong.
There was a problem hiding this comment.
hmmm hotfix branches still go through a pull request, am I wrong? If that's the case, we don't need to add them in branches
There was a problem hiding this comment.
Changes made in hotfix branches do go through a pull request, but the release itself is a direct push to the hotfix branch, just like the release of a new .0 version is a direct push to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two avoid CI running twice, once on branch push and another time on pull requests.