Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 💥 new environment and volume var naming #1729

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from
Draft

feat: 💥 new environment and volume var naming #1729

wants to merge 26 commits into from

Conversation

nemchik
Copy link
Member

@nemchik nemchik commented Feb 19, 2024 •
edited

Pull request

Purpose

  • Variable naming now tries to be <appname>_<section>_<varname> where <section> is new and mostly made up of either ENVIRONMENT or VOLUME
  • Nicer handling for VOLUME variables in scripts
  • Make the docker socket volume a variable for any app using it
  • Deprecate all downloader+vpn container, recommend using gluetun/privoxyvpn instead
  • Remove VPN specific variables
  • Azuracast has some breaking changes to variables to bring it more in-line with other app templates
  • Remove logging sections from all app templates (this simplifies the compose file and allows the user to configure a global default on their own or override individual apps easier)
  • Fixed an incorrectly used variable in AMD
  • Add Doplarr
  • Add FireflyIII
  • Add ports, vars, and tun device for Gluetun
  • Add Kitana
  • Remove unused password variable from Limnoria
  • Rename (and migrate) minecraft servers to remove _ from appnames
  • Deprecate Ouroboros
  • Add Overseerr
  • Add Petio
  • Deprecate Samba
  • Adjust wireguard server var naming slightly

Requirements
Check all boxes as they are completed

@nemchik nemchik requested review from a team as code owners February 19, 2024 02:35
@github-actions github-actions bot added ci Automatic label apps Automatic label docs Automatic label core Automatic label repo Automatic label labels Feb 19, 2024
@nemchik nemchik force-pushed the variable-naming branch 4 times, most recently from 1e4f054 to 76dc44d Compare February 19, 2024 03:13
@nemchik
feat: 💥 new environment and volume var naming
a829ea2 
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@nemchik nemchik marked this pull request as draft February 19, 2024 03:22
@nemchik
fix: 🐛 rearrange sanitize
e550173 
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@nemchik
fix: 🐛 only rename vars when FROMVAR exists
6ecf0a7 
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@nemchik
fix: 🐛 leave legacy vars untouched
ae2ada8 
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@nemchik
fix: 🐛 include additional untouched globals
e1c4d18 
Signed-off-by: Eric Nemchik <eric@nemchik.com>
This was referenced Feb 20, 2024
Draft
Open
nemchik and others added 9 commits February 22, 2024 20:46
@nemchik
Merge branch 'master' into variable-naming
4832dbc
@nemchik
fix: 🐛 keep dir in existing volume names
30c1623 
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@nemchik
fix: 🐛 redirect requestrr override
3e89127 
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@nemchik
style: ⚰️ reduce PR size
2842e8a 
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@nemchik
fix: 🐛 add missing privoxyvpn vars
7b57cd9 
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@nemchik
Merge branch 'master' into variable-naming
d147fc0
@CLHatch
Fix PLEX_CLAIM variable in Plex
fd64526 
Fix `PLEX_ENVIRONMENT_CLAIM` TO `PLEX_ENVIRONMENT_PLEX_CLAIM`
@CLHatch
Add missing Gluetun variables and ports
ecc1419 
Add the missing `gluetun` variables and ports, set to the defaults listed in the gluetun wiki.
@CLHatch
Update gluetun.labels.yml
9fa05dc
CLHatch and others added 11 commits March 5, 2024 10:33
@CLHatch
Update gluetun.labels.yml
e4aa6cc 
Remove whitespace on last line
@CLHatch
Update gluetun.labels.yml
cc680fc 
Add missing end quote
@nemchik
chore: 🚚 rename functions and fix regex
af8939b 
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@nemchik
feat: 🚚 only run migrate on enabled apps
83a6621 
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@CLHatch
Remove gluetun variables for DNS
8833b7d 
Remove `gluetun` variables for DNS
https://github.com/qdm12/gluetun-wiki/blob/main/setup/options/dns.md
@CLHatch
Remove gluetun variables for Healthcheck
77e4bc4 
Remove `gluetun` variables for Healthcheck
https://github.com/qdm12/gluetun-wiki/blob/main/setup/options/healthcheck.md
@CLHatch
Remove gluetun variables to change the three listen addresses
5907fe2 
Remove `gluetun` variables to change the three listen addresses

https://github.com/qdm12/gluetun-wiki/blob/main/setup/options/control-server.md
`HTTP_CONTROL_SERVER_ADDRESS`=`:8000`

https://github.com/qdm12/gluetun-wiki/blob/main/setup/options/http-proxy.md
`HTTPPROXY_LISTENING_ADDRESS`=`:8888`

https://github.com/qdm12/gluetun-wiki/blob/main/setup/options/shadowsocks.md
`SHADOWSOCKS_LISTENING_ADDRESS`=`:8388`
@nemchik
Merge branch 'master' into variable-naming
3f3bc4b
@nemchik
Merge pull request #1739 from CLHatch/variable-naming
9129e98 
Fix some incorrect and missing variables
@nemchik
fix: 📦 un-deprecate vpn containers
6bb659d 
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@nemchik
fix: 📦 un-deprecate vpn containers (mkdocs)
d6d91d2 
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@nemchik nemchik mentioned this pull request Apr 28, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
apps Automatic label ci Automatic label core Automatic label docs Automatic label repo Automatic label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nemchik @CLHatch