Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we load mod resources correctly on Geyser-NeoForge #4651

Merged
merged 2 commits into from May 12, 2024
Merged

Ensure we load mod resources correctly on Geyser-NeoForge #4651

merged 2 commits into from May 12, 2024

Conversation

onebeastchris
Copy link
Member

This also adds support for a theoretical floodgate-neoforge mod.

@onebeastchris onebeastchris added the PR: Bugfix When a PR contains a bugfix label May 9, 2024
Camotoy
Camotoy approved these changes May 12, 2024
View reviewed changes
Copy link
Member

@Camotoy Camotoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this doesn't break anything (I guess I'm worried about that shadow move, but really that was just done in the JiJ PR, wouldn't it have), then LGTM.

@onebeastchris onebeastchris merged commit 86dafbc into GeyserMC:master May 12, 2024
2 checks passed
@onebeastchris onebeastchris deleted the neoforge-is-annoying branch May 12, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camotoy Camotoy Camotoy approved these changes

Assignees
No one assigned
Labels
PR: Bugfix When a PR contains a bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@onebeastchris @Camotoy