Emulate client side vehicle movement #4648
Open
+1,568
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kas-tle
added
the
PR: Needs Testing
Camotoy
reviewed
May 15, 2024
core/src/main/java/org/geysermc/geyser/entity/vehicle/VehicleComponent.java
Outdated
Show resolved
Hide resolved
Redned235
requested changes
May 15, 2024
|
|
||
| Vector2f getAdjustedInput(Vector2f input); | ||
|
|
||
| boolean isLogicalSideForUpdatingMovement(); |
There was a problem hiding this comment.
I know this is a method name pulled from NMS, but I'm not a huge fan of the naming. The name doesn't line up very well with what the method actually checks for.
There was a problem hiding this comment.
maybe isClientControlled() (or similar)?
There was a problem hiding this comment.
I agree the name isn't great. Chris' suggestion sounds good to me so I used that for now
AJ-Ferguson
added
the
PR: Needs review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for vehicles that are controlled by the client (Camel, Strider, Pig).
Movement should be extremely close to a real java client, and many situations are accurately handled such as fluid, slime and honey blocks, climbing, etc.
Todo