Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show github actions build number in startup log and version check command #4336

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Show github actions build number in startup log and version check command #4336

wants to merge 15 commits into from

Conversation

onebeastchris
Copy link
Member

@onebeastchris onebeastchris commented Dec 13, 2023 •
edited

Changes made:

TODO's:

  • yeet md5 hash from dump? - the downloads api does not provide it

Would fix #1748

@onebeastchris
Version checker shows build number
e542906 
Don't check build number if running a dev build
Show dev build warning in console
@onebeastchris onebeastchris mentioned this pull request Dec 13, 2023
Merged
@onebeastchris onebeastchris added PR: Feature When a PR implements a new feature PR: Cosmetic When a PR adds something that is purely cosmetic, like changing the README labels Dec 13, 2023
@onebeastchris onebeastchris added the PR: Needs review Indicates that a PR is functional and review-ready. label Dec 16, 2023
Camotoy
Camotoy reviewed Dec 19, 2023
View reviewed changes
core/build.gradle.kts Outdated Show resolved Hide resolved
Tim203
Tim203 requested changes Dec 31, 2023
View reviewed changes
core/build.gradle.kts Outdated Show resolved Hide resolved
core/src/main/java/org/geysermc/geyser/GeyserImpl.java Outdated Show resolved Hide resolved
core/src/main/java/org/geysermc/geyser/GeyserImpl.java Outdated Show resolved Hide resolved
onebeastchris and others added 5 commits January 2, 2024 17:42
@onebeastchris
Change isDevBuild() function to instead be set in the build script
1fe027e 
Changed GeyserImpl.VERSION to consist of build number (e.g 420) + git info instead of geyser version (2.2.0-SNAPSHOT) + git info
@onebeastchris @Tim203
yeet jenkins variable
3442b97 
Co-authored-by: Tim203 <mctim203@gmail.com>
@onebeastchris
Merge remote-tracking branch 'upstream/master' into build-number
5b05956
@onebeastchris
- make version either "2.3.0-SNAPSHOT" if dev, or "2.3.0-b54" if non …
89087e0 
…dev to reflect build version

- make isDev a variable in the GitInfo class
@onebeastchris
Also adapt version command
ec325ff
@onebeastchris onebeastchris added PR: On hold When a PR is on hold like if it requires a dependency to be updated first and removed PR: Needs review Indicates that a PR is functional and review-ready. labels Jan 22, 2024
@Kas-tle
Copy link
Member

Kas-tle commented Apr 20, 2024

Must be adapted as build number is no longer pulled directly from GH actions and instead uses the env variable BUILD_NUMBER.
See https://github.com/GeyserMC/Geyser/pull/4583/files#diff-a6fced4b4e4a99784a2b92028b1adbc8c0ca28ff54e264b0e73727b3d4a460cf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Konicai Konicai Konicai left review comments

@Tim203 Tim203 Tim203 approved these changes

@Camotoy Camotoy Camotoy approved these changes

@Kas-tle Kas-tle Kas-tle approved these changes

Assignees
No one assigned
Labels
PR: Cosmetic When a PR adds something that is purely cosmetic, like changing the README PR: Feature When a PR implements a new feature PR: On hold When a PR is on hold like if it requires a dependency to be updated first
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include Build Number in Start logs and /geyser version
5 participants
@onebeastchris @Kas-tle @Tim203 @Camotoy @Konicai