Receive command descriptions from floodgate #4216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Camotoy
reviewed
Oct 15, 2023
| byte[] data = packet.getData(); | ||
| String dataString = new String(data, StandardCharsets.UTF_8); | ||
|
|
||
| Map<String, String> parsedCommandDescriptions = new Gson().fromJson(dataString, new TypeToken<Map<String, String>>(){}.getType()); |
There was a problem hiding this comment.
This doesn't need to be JSON. See: Camotoy@cf8eb0d#diff-102f70618eda60c10b2a4991aaa3ce1551f602a9f970442fa9dfffceeae6c18bR59
There was a problem hiding this comment.
This doesn't need to be JSON. See: Camotoy@cf8eb0d#diff-102f70618eda60c10b2a4991aaa3ce1551f602a9f970442fa9dfffceeae6c18bR59
Added binary format
|
Requires rebase or merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows geyser standalone to have access to command description data forwarded from floodgate in my other PR: GeyserMC/Floodgate#460