Add a /geyser ping command #4131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If Geyser's languages submodule is updated before the cloud PR is merged, I need to fix usages by the master branch of certain lang strings, before the submodule is updated. This is alright, I'm just saying it needs to be done first. |
|
This PR can totally wait until after cloud is merged, it's by no means urgent :) |
onebeastchris
added
PR: Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3552 to show the ping between the Bedrock client <-> Geyser server.
Huge thanks to rk_01 for the help!
Note: There are two methods in
RakSessionCodecthat can be used for this purpose - not fully sure which one would be the best to use here. Both seemed to have similar values during testing.Requires GeyserMC/languages#117 for the lang strings.
Closes #3552, closes #4379