Add a commands.yml file for specifying custom command descriptions #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konicai
reviewed
Dec 26, 2021
| CommandManager getGeyserCommandManager(); | ||
| @Contract("_ -> new") | ||
| default CommandManager createGeyserCommandManager(GeyserImpl geyser) { | ||
| return new CommandManager(geyser); |
There was a problem hiding this comment.
Just a heads up that in my Sponge PR I'll have to change this javadoc to "allow" platforms to provide an existing command manager, since the sponge command manager needs to be created before the connector. There are some other things on my mind as well but they're manageable.
Also the _ in the contract infers null values are allowed as per jetbrains docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command descriptions are not forwarded as a part of the standard Java protocol. Even if we implement this - which is likely - Spigot for example has "A Mojang provided command" for all Mojang commands. These changes allow users to specify custom descriptions for commands.