Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Build Number in Start logs and /geyser version #1748

Open
Chew opened this issue Dec 27, 2020 · 3 comments · May be fixed by #4336
Open

Include Build Number in Start logs and /geyser version #1748

Chew opened this issue Dec 27, 2020 · 3 comments · May be fixed by #4336
Assignees
@onebeastchris
Labels
Feature Request A feature request. Work in Progress The issue is currently being worked on.

Comments

@Chew
Copy link
Member

Chew commented Dec 27, 2020

What feature do you want?
It would be nice to see the Build number in the startup logs to see what build you're on in case something goes sour and you can't make a dump.

Additionally, seeing it in /geyser version is a clear indication of how many builds you are, and it would be nice if it could mimic the behavior of /icanhasbukkit and show how many builds behind you are.

Alternatives?
Crying myself to sleep never knowing what build I'm on
@Chew Chew added the Feature Request A feature request. label Dec 27, 2020
@jkcoxson
Copy link

This is a great idea, although may not work in practice. CI handles the build numbering. What we could do instead is what Dolphin does; include the git hash in Geyser versioning to compare what version you are on.

@Camotoy
Copy link
Member

Camotoy commented Dec 27, 2020

We include a git.properties file that holds the build number.

@jkcoxson
Copy link

jkcoxson commented Dec 27, 2020 •
edited

The jar or plugin, which people are downloading and using, does not create git.properties. I think that is the feature request here. From what I know about the code, it creates it on build.

Geyser/connector/pom.xml

Line 219 in d1c571d

<generateGitPropertiesFilename>${project.build.outputDirectory}/git.properties</generateGitPropertiesFilename>

@onebeastchris onebeastchris linked a pull request Dec 13, 2023 that will close this issue
Open
@onebeastchris onebeastchris added the Work in Progress The issue is currently being worked on. label Dec 13, 2023
@onebeastchris onebeastchris self-assigned this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onebeastchris onebeastchris

Labels
Feature Request A feature request. Work in Progress The issue is currently being worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show github actions build number in startup log and version check command onebeastchris/Geyser
4 participants
@Chew @Camotoy @jkcoxson @onebeastchris