[Improvement]Testing #352
Merged
[Improvement]Testing #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 馃毇 Danger |
ipavlidakis
force-pushed
the
improvements/improve-testing
branch
from
3b1e4af
to
8a00d39
Compare
ipavlidakis
force-pushed
the
improvements/improve-testing
branch
from
568002f
to
7e9b703
Compare
ipavlidakis
force-pushed
the
improvements/improve-testing
branch
from
7e9b703
to
857eea8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃幆 Goal
This PR attempts to provide an infrastructure that will allow us to test our Core flow using unit tests. This is crucial to increase our confidence on product stability but also to remove our dependency on UI tests that as they increase in number are slowing our pipelines.
馃洜 Implementation
The new
Mockableimplementation provides a consistent way that allows the creation of mocks for any reference value type while allowing mocking it's method calls. It relies on dynamicmemberlookup and function overrides.馃帹 Showcase
The updated
CallKitServiceTestsprovide a demonstration of the new Mockable implementation. For the purpose of the tests we have provided mocks for StreamVideo and Call, both are core objects in our stack.鈽戯笍 Contributor Checklist