Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time series web mapping with leaf map draft notebook #986

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

s-m-t-c
Copy link
Collaborator

@s-m-t-c s-m-t-c commented Jan 5, 2023

Proposed changes

This is a concept notebook for a functionality I haven't seen well documented for visualising time-series spatial data in a jupyter nb.

Checklist (replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with

@s-m-t-c s-m-t-c requested review from robbibt and cbur24 January 5, 2023 02:21
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@robbibt
Copy link
Collaborator

robbibt commented Jan 8, 2023

Hey @s-m-t-c, thanks so much for putting this together - I think it will be a great addition to the repo (have been wanting to get some Leafmap examples in here for ages too). Unfortunately there's a bit of an issue with widgets on the Sandbox at the moment, causing the map to not appear for me:
image

This is currently being worked on, so will hopefully have a solution soon. The other thing we'll need to do is get leafmap installed by default on the Sandbox - do you currently install any specific version, or just pip install leafmap to get the latest?

@s-m-t-c
Copy link
Collaborator Author

s-m-t-c commented Feb 6, 2023

@robbibt I understand you're still working on the widget issue. Use the latest version of leafmap for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants