Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add csv export to DEA WIT notebook #1222

Merged
merged 15 commits into from May 9, 2024
Merged

add csv export to DEA WIT notebook #1222

merged 15 commits into from May 9, 2024

Conversation

BexDunn
Copy link
Collaborator

@BexDunn BexDunn commented Apr 18, 2024

Proposed changes

Adds a csv export to the WIT notebook, explains the data in the export

Checklist

(Replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@BexDunn BexDunn marked this pull request as draft April 18, 2024 04:24
@BexDunn
Copy link
Collaborator Author

BexDunn commented Apr 18, 2024

I haven't managed to catch the previously updated knowledge hub links in this correctly, so have converted it to draft for now

@BexDunn BexDunn marked this pull request as ready for review April 22, 2024 00:05
Copy link
Collaborator

@LaurenSchenk1 LaurenSchenk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me :)

@benji-glitsos-ga
Copy link
Collaborator

Hi Bex,

It looks great. Some minor notes about the links:

Copy link
Collaborator

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BexDunn, this looks great to me. Two small suggestions:

  1. Change the Explorer links from "https://explorer.sandbox.dea.ga.gov.au/products/..." to ""https://explorer.dea.ga.gov.au/products/..." (our public facing URLs are now "https://explorer.dea.ga.gov.au" for AWS and "https://explorer.nci.dea.ga.gov.au" for NCI)
  2. For links to notebooks and Python code, I'd personally prefer for us continuing to use relative links wherever possible rather than an external link to Knowledge Hub - it means that users can quickly open up the code directly on the Sandbox, but should still work in the rendered notebooks on Github and Knowledge Hub. So, I'd potentially prefer the one on the left here to the one on the right:
    image

(I think you can still link to specific notebook headers in the same way you have already, just keeping the relative part of the link at front)

@BexDunn BexDunn merged commit d03bf49 into develop May 9, 2024
1 check passed
@BexDunn BexDunn deleted the wit_csv_update branch May 9, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ideas and improvements 💡
Development

Successfully merging this pull request may close these issues.

None yet

4 participants