New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add csv export to DEA WIT notebook #1222
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I haven't managed to catch the previously updated knowledge hub links in this correctly, so have converted it to draft for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me :)
Hi Bex, It looks great. Some minor notes about the links:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BexDunn, this looks great to me. Two small suggestions:
- Change the Explorer links from "https://explorer.sandbox.dea.ga.gov.au/products/..." to ""https://explorer.dea.ga.gov.au/products/..." (our public facing URLs are now "https://explorer.dea.ga.gov.au" for AWS and "https://explorer.nci.dea.ga.gov.au" for NCI)
- For links to notebooks and Python code, I'd personally prefer for us continuing to use relative links wherever possible rather than an external link to Knowledge Hub - it means that users can quickly open up the code directly on the Sandbox, but should still work in the rendered notebooks on Github and Knowledge Hub. So, I'd potentially prefer the one on the left here to the one on the right:
(I think you can still link to specific notebook headers in the same way you have already, just keeping the relative part of the link at front)
Proposed changes
Adds a csv export to the WIT notebook, explains the data in the export
Checklist
(Replace
[ ]
with[x]
to check off)Load packages
General advice
)jupyterlab_code_formatter
tool can be used to format code cells to a consistent style: select each code cell, then clickEdit
and then one of theApply X Formatter
options (YAPF
orBlack
are recommended).NCI
andDEA Sandbox
(flag if not working as part of PR and ask for help to solve if needed)Notebook currently compatible with the NCI|DEA Sandbox environment only
line below the notebook title to reflect the environments the notebook is compatible with