Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DEAfrica Wetland Turbidity notebook for Australian study site #1175

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Matt-dea
Copy link
Collaborator

Proposed changes

Adding a modified version of the DE Africa Wetlands Turbidity notebook using an Australian study site.

Closes issues (optional)

  • Closes Issue #000

Checklist

(Replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@smith-kyle
Copy link

Just a heads up, you can review these notebook changes with GitNotebooks too: https://gitnotebooks.com/GeoscienceAustralia/dea-notebooks/pull/1175

I think it offers some advantages over what you're currently using.

Copy link
Collaborator

@BexDunn BexDunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Matt! Great notebook!

Two requests - can you please go for a small area or add some dask, as this one takes a really long time to run in the standard sandbox, and; can you please add a comment talking about the range of the index and interpreting the results after the first plot? It would be nice to know what the max/min negative/postive values are, and the significance of negative vs. positive values.

I've made a couple of other small changes, to the design, grammar and updated the explorer links and replaced C2 WO summary with C3, and replaced all incidences of NDTI with NDTI2. Hope that makes sense, let me know what you think.

Thanks for doing this, it's looking pretty amazing and it will be great to add it to our repertoire.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants