Fix nodata value in ga_srtm_dem1sv1_0 product
#1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1348 (opendatacube/datacube-core#1348) discusses issues with the nodata value in the
ga_srtm_dem1sv1_0SRTM DEM product. It appears that the issue is caused by the nodata value being truncated and losing precision when converted to scientific notation format, which then prevents it from being applied correctly by funcs likefrom datacube.utils.masking import mask_invalid_data.This PR attempts to fix this issue by using the full non-truncated nodata string instead of the shorter scientific notation.