Refactor/eliminate include directives #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elias-tsigaridas is this ready for review? |
|
It is ready for review, IMO. |
vissarion
approved these changes
Nov 4, 2022
| #include "cartesian_geom/cartesian_kernel.h" | ||
| #include "random_walks/random_walks.hpp" | ||
| #include "volume/volume_sequence_of_balls.hpp" | ||
| #include "volume/volume_cooling_gaussians.hpp" | ||
| #include "volume/volume_cooling_balls.hpp" | ||
| #include "misc.h" | ||
| #include "misc/misc.h" |
There was a problem hiding this comment.
This is not related to this PR but I think it is better to call this directory util from utilities then we will see what to do with misc.h Ideally it will be renamed to something more descriptive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the #include directives in the files in the directory test/ (and in some in the directory include/)
so that we depend only on the directories include/ and external/
I also modified the CMakeLists.txt file accordingly to include these two directories only.