Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.xml #4

Open
wants to merge 1 commit into
base: cm-12.1
Choose a base branch
from
Open

Conversation

ililaoban
Copy link

fix bug

@skinzor
Copy link

skinzor commented Mar 9, 2017

I'm curious, what bug?

When I've built RR 5.1.1 I had to delete this line to get rid of the build error.

@ililaoban
Copy link
Author

@skinzor well,I've built cm12.1 and added this line to get rid of the build error.Maybe cm need this line but RR doesn"t.

@skinzor
Copy link

skinzor commented Mar 10, 2017

@ililaoban I see. On RR I had to delete this line in order to get rid of build error.

@ililaoban
Copy link
Author

@skinzor by the way,did you edit overlay when you built RR?

@skinzor
Copy link

skinzor commented Mar 11, 2017

@ililaoban I don't really remember. Why you're asking?

@ililaoban
Copy link
Author

@skinzor well, I've just built a MoKee5.1.but got bootloop with bootanimation.Can you give me some help?

@skinzor
Copy link

skinzor commented Mar 11, 2017

@ililaoban Well, you have to take a logcat. Also note that i have low knowledge.

But this is going "off topic" :D.

@mixaz
Copy link

mixaz commented Apr 4, 2017

I'm facing the same issue too, compiling against cm 12.1 branch:

target R.java/Manifest.java: Telecom (/home/build/android/cm12.1/out/target/common/obj/APPS/Telecom_intermediates/src/R.stamp)
device/samsung/j5-common/overlay/packages/services/Telecomm/res/values/config.xml:16: error: Resource at config_speed_up_audio_on_mt_calls appears in overlay but not in the base package; use <add-resource> to add.
build/core/package_internal.mk:232: recipe for target '/home/build/android/cm12.1/out/target/common/obj/APPS/Telecom_intermediates/src/R.stamp' failed
make: *** [/home/build/android/cm12.1/out/target/common/obj/APPS/Telecom_intermediates/src/R.stamp] Error 1

It appears that there's a conflict with patch in base code Galaxy-J5/android_packages_services_Telecomm@32d4c49 so the overlay needs to be updated accordingly.

The PR is wrong, config_speed_up_audio_on_mt_calls needs to be removed instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants