Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging forked repos #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Merging forked repos #423

wants to merge 1 commit into from

Conversation

sonomirco
Copy link
Collaborator

This implementation should solve the issue we have once we merge branches from forked repos.

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

Little fixing solves the issue of releasing from forked repos.

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 docs
  • 🙅 no documentation needed

This implementation should solve the issue we have once we merge branches from forked repos.
@sonomirco sonomirco added bug 🐛 Issues describing a bug or pull requests fixing a bug. patch Pull requests requiring a patch version update according to semantic versioning. labels Aug 13, 2023
@sonomirco sonomirco requested a review from d3ssy August 13, 2023 02:45
@sonomirco sonomirco self-assigned this Aug 13, 2023
@sonomirco sonomirco added this to In progress in Core via automation Aug 13, 2023
@d3ssy d3ssy self-requested a review August 27, 2023 09:09
@d3ssy
Copy link
Collaborator

d3ssy commented Aug 27, 2023

We can do this, but doesn't it open up the possibility for outside collaborators to run ANY action on this repo?!

The docs recommend enabling forks for outside collaborators but review and approve their workflows in the PR.

Tbh I never noticed that approval option in the PR... or looked for it lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issues describing a bug or pull requests fixing a bug. patch Pull requests requiring a patch version update according to semantic versioning.
Projects
Core
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants