Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odilkhan Yakubov PR commits #674

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

odil24
Copy link

@odil24 odil24 commented Mar 26, 2024

EFFECT OF CHANGE

  • Fix: removed params because of Viewport rendering;
  • Fix: Unhide Upscale and Viewport denoising and minor changes;
  • Improved: increased syncronization performance for Viewport/Material preview when mesh sync;
  • Improved: viewport rendering.

In previous v3.5.x it has these options but after v3.5.2 it just disappeared and made some issues. Now these are fixed and backported
@odil24
Copy link
Author

odil24 commented Mar 26, 2024

@VascoPi @DagerD @bnagirniak Please, review changes

@DagerD
Copy link
Contributor

DagerD commented Mar 26, 2024

I don't work on this project anymore. Probably, you need to call @feniksa

@feniksa
Copy link
Contributor

feniksa commented Mar 26, 2024

HI @odil24

Thank you for your contribution. This PR will be reviewed and process as soon as possible.

@odil24
Copy link
Author

odil24 commented Apr 7, 2024

@feniksa please, review and release

@feniksa
Copy link
Contributor

feniksa commented Apr 9, 2024

@odil24 we need additional time for preparing plugin for blender 4.1. We need some additional time.

Thank you

@odil24
Copy link
Author

odil24 commented Apr 9, 2024

@odil24 we need additional time for preparing plugin for blender 4.1. We need some additional time.

Thank you

Ok. So I will continue add commits to my PR, ok?

@takahiroharada
Copy link
Collaborator

@odil24 we merged another PR to support 4.1 which is causing some conflicts. Can you merge main to this branch once?

@odil24
Copy link
Author

odil24 commented May 24, 2024

@odil24 we merged another PR to support 4.1 which is causing some conflicts. Can you merge main to this branch once?

Hi. But how to do this?

@takahiroharada takahiroharada mentioned this pull request May 28, 2024
@feniksa
Copy link
Contributor

feniksa commented May 31, 2024

@odil24 Rebase to latest master.

src/rprblender/engine/viewport_engine_2.py Show resolved Hide resolved
src/rprblender/engine/viewport_engine_2.py Show resolved Hide resolved
src/rprblender/engine/viewport_engine_2.py Show resolved Hide resolved
src/rprblender/engine/viewport_engine_2.py Show resolved Hide resolved
src/rprblender/engine/viewport_engine_2.py Show resolved Hide resolved
src/rprblender/export/mesh.py Show resolved Hide resolved
src/rprblender/export/mesh.py Show resolved Hide resolved
src/rprblender/export/mesh.py Show resolved Hide resolved
src/rprblender/export/mesh.py Show resolved Hide resolved
src/rprblender/export/mesh.py Show resolved Hide resolved
@feniksa
Copy link
Contributor

feniksa commented May 31, 2024

Please, rebase to latest master

Copy link
Author

@odil24 odil24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it normal now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants