Format entire codebase with eslint config #1389
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Processing remaining eslint warnings is time consuming but potentially good to do anyways. If anyone wants to contribute it's just busywork for the most part |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESlint does not do any formatting of the source code currently. This adds a massive ESlint formatting of the codebase
Pros: Fails PR for bad formatting, better general standards for formatting for project
Cons: makes git blame difficult, doesn't format comments very well so some comments are weirdly formatted from this, makes any fork projects in a bad place to sync up
Also, not passing the eslint standards just yet so still in progress