Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix : Event in List is not bookmarked/unbookmarked #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

anushreeag
Copy link
Contributor

when event is bookmarked/unbookmarked in detail Activity

…d/unbookmarked in detail Activity and we return to List of events
@anushreeag
Copy link
Contributor Author

@jaysondc @ganeshskudva : Do we need intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK); while starting DetailActivity ?

@jaysondc
Copy link
Contributor

jaysondc commented Nov 8, 2017

I don't think it needs to be to be a NEW_TASK. That flag causes the system to launch the activity in a whole separate task stack, with a different animation than when you normally launch an activity. This would probably break our shared element transition as well. We should be able to keep the launch mode as NORMAL which is described as the following:

Default. The system creates a new instance of the activity in the task from which it was started and routes the intent to it. The activity can be instantiated multiple times, each instance can belong to different tasks, and one task can have multiple instances.

This is correct because even if an instance of DetailActivity exists somewhere in the background, we want to launch a separate instance so it loads via a new intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants