Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃洜 Tooling: dist/ web game directories should be fully portable #312

Open
3 tasks done
JoshuaKGoldberg opened this issue Aug 19, 2022 · 0 comments
Open
3 tasks done

馃洜 Tooling: dist/ web game directories should be fully portable #312

JoshuaKGoldberg opened this issue Aug 19, 2022 · 0 comments
Labels
area: tooling Builds, infrastructure, packages, and other repository management package: shenanigans-manager status: accepting prs Go ahead and send a pull request to resolve this issue!

Comments

@JoshuaKGoldberg
Copy link
Member

Tooling Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

It should be the case that you can open a game's dist/index.html anywhere:

git clone https://github.com/JoshuaKGoldberg/ChooseYourFramework
cd ChooseYourFramework
yarn hydrate
yarn dist
open dist/index.html

...but, alas, that is not yet the case. Let's fix up those paths. Any change to href/src/etc. paths from https://github.com/JoshuaKGoldberg/ChooseYourFramework/blob/0a18b19632b5f321e990748ce8ddb9b5588e005f/fix-index-for-vercel.js#L18 should be incorporated into shenanigans-manager.

Additional Info

Consider this split out of #311.
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Go ahead and send a pull request to resolve this issue! package: shenanigans-manager area: tooling Builds, infrastructure, packages, and other repository management labels Aug 19, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 19, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Builds, infrastructure, packages, and other repository management package: shenanigans-manager status: accepting prs Go ahead and send a pull request to resolve this issue!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg