Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Performance: Combine all delay-loaded chunks into one #313

Open
2 tasks done
JoshuaKGoldberg opened this issue Aug 19, 2022 · 0 comments
Open
2 tasks done
Assignees
Labels
area: performance Improving the speed of games. package: shenanigans-manager status: accepting prs Go ahead and send a pull request to resolve this issue!

Comments

@JoshuaKGoldberg
Copy link
Member

Performance Report Checklist

Overview

Right now as of https://github.com/JoshuaKGoldberg/ChooseYourFramework/tree/0a18b19632b5f321e990748ce8ddb9b5588e005f, https://chooseyourframework.dev loads the following scripts from require.min.js (so, after the game loads):

  • preact.umd.js
  • UserWrappr-Delayed.js
  • hooks.umd.js (Preact)
  • jsxRuntime.umd.js (Preact)

So many libraries! Let's combine them all into one happy little bundle. Say, {{ shenanigans.name }}-Delayed.js (e.g. ChooseYourFramework-Delayed.js).

Additional Info

Tangentially related to #312. It'll be easier for everything to be portable if there's only one chunk to be delay-loaded, and that chunk is plopped into the dist/ directory.

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Go ahead and send a pull request to resolve this issue! package: shenanigans-manager area: performance Improving the speed of games. labels Aug 19, 2022
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Aug 19, 2022
@JoshuaKGoldberg JoshuaKGoldberg removed this from the ChooseYourFramework Release milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: performance Improving the speed of games. package: shenanigans-manager status: accepting prs Go ahead and send a pull request to resolve this issue!
Projects
None yet
Development

No branches or pull requests

1 participant