Name clash in star imports should result in error when the name is used #5963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh-on-star-imports
…s been imported more than once
jjcnn
changed the title
Benchmark for c1e6d19Click to view benchmark
|
Benchmark for f0511ddClick to view benchmark
|
Benchmark for 156a15bClick to view benchmark
|
Benchmark for 3d7f425Click to view benchmark
|
Benchmark for a345357Click to view benchmark
|
tritao
reviewed
May 9, 2024
test/src/e2e_vm_tests/test_programs/should_pass/language/import_star_name_clash/Forc.toml
Show resolved
Hide resolved
tritao
reviewed
May 9, 2024
tritao
reviewed
May 9, 2024
|
Left a couple suggestions, but overall really nice improvements here @jjcnn, great stuff. |
Is it? I think of it as a bugfix. In any case the change will not change the behavior of programs that successfully compile. Compilation will only fail some programs that used to compile without error. |
…s/sway into jjcnn/name-clash-on-star-imports
|
Review comments addressed. There is one outstanding bug: When the name is bound to an enum variant, we report I'll fix this issue later today, and update the failing test accordingly. |
Benchmark for a188b6bClick to view benchmark
|
|
Final issues fixed. |
tritao
previously approved these changes
May 10, 2024
Benchmark for e16c46dClick to view benchmark
|
tritao
approved these changes
May 11, 2024
IGI-111
approved these changes
May 11, 2024
Benchmark for ffeda73Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5940.
This PR deals with the situation where the same name is imported by multiple star imports, e.g.,
So far we have resolved this name clash by letting the latter import shadow the former, which is incorrect.
The correct behavior is to allow the import without error, but to report an error if the unqualified name (i.e.,
X) is used (qualified namesa::Xandb::Xare legal)`. This PR fixes this problem.Note that if
Xis imported multiple times, but each time is bound to the same entity (e.g., because it is imported both throughcore:;preludeandcore::codec), then this should not cause an error.Note also that there is a problem with the implicit imports from the core and std preludes, which in some cases causes the implementation to think that a name is bound to multiple different entities, even though the entities are actually the same. As a workaround anytime a name is imported from either
stdorcorewhen it is already imported fromstdorcore, the new binding replaces the old one instead of being added as a new binding.Unfortunately this workaround means that it is not currently possible to redefine and use a name that exists in
stdorcore, e.g., to create a specialized version ofassert_eqas is done in one of our tests. To use such a redefinition one must use a qualified name for the entity, which seems like an acceptable workaround. (Note that this only applies if the redefined entity is imported using a star import - if imported using an item import (use a::X;), then there is no issue).Once #3487 is implemented this workaround should no longer be necessary.
Checklist
Breaking*orNew Featurelabels where relevant.