Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --bech32 flag to forc contract-id command #5943

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ADTmux
Copy link

@ADTmux ADTmux commented May 2, 2024

Description

Issue : https://github.com/FuelLabs/sway/issues/5842

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Amit Dave seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ADTmux
Copy link
Author

ADTmux commented May 2, 2024

working on updating docs. Please feel free to let me know if any areas need rework/update

@ADTmux ADTmux changed the title Added --bech-32 flag to forc contract-id command Added --bech32 flag to forc contract-id command May 2, 2024
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A possible issue with the dependency you added, so blocking for now as I need to make sure some stuff first. If that is the case I will provide you more guidance how to move around the issue with the dependency

@@ -32,6 +32,9 @@ pub struct Command {
/// Disable the "new encoding" feature
#[clap(long)]
pub no_encoding_v1: bool,
// flag to display contract-id in bech32 format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// flag to display contract-id in bech32 format
// Flag to display contract-id in bech32 format

@@ -29,6 +29,7 @@ forc-tracing = { version = "0.56.0", path = "../forc-tracing" }
forc-util = { version = "0.56.0", path = "../forc-util" }
fs_extra = "1.2"
fuel-asm = { workspace = true }
fuels-core = { workspace = true }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency here will likely create an issue for us. Due to our internal procedures we require forc not to depend on sdk. We should be able to move around this somehow. I will think about a different way of doing this but first I wanted to make sure this is not allowed by our CI.

@kayagokalp
Copy link
Member

Also please run cargo fmt so that CI fails go away :) and make sure to run cargo build and commit the cargo.lock file since you added a depenedncy cargo.lock should be changed. But that is not commited here.

@kayagokalp kayagokalp added enhancement New feature or request forc labels May 2, 2024
@ADTmux
Copy link
Author

ADTmux commented May 4, 2024

@kayagokalp I did see the fact that we are generating the documentation for all forc commands in the Sway Book by running forc --help, but could I get any pointers to any past PRs (of how the html files are built), or as to how we are doing that? I want to add the --bech32 in the Sway Book.

@kayagokalp
Copy link
Member

@kayagokalp I did see the fact that we are generating the documentation for all forc commands in the Sway Book by running forc --help, but could I get any pointers to any past PRs (of how the html files are built), or as to how we are doing that? I want to add the --bech32 in the Sway Book.

Hey, no worries about that we have a mdbook preprocessor that automatically does that. So it is done via CI not manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request forc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants