Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Mapping::find_match to return error when multiple replacements are possible. #5610

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve Mapping::find_match to return error when multiple replacements are possible. #5610

wants to merge 2 commits into from

Conversation

AbhinavMir
Copy link

@AbhinavMir AbhinavMir commented Feb 14, 2024 •
edited

Potential fix #5540

Seemed to be a simple syntax error, runs fine when fixed, lmk if this looks right

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@esdrubal
Copy link
Contributor

Fixing the issue will require removing duplicated types from the DeclMapping. This will require some debugging to fix the current failures in the test suite.
https://github.com/FuelLabs/sway/actions/runs/7895537004/job/21647644809?pr=5610#step:6:9150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Mapping::find_match to return error when multiple replacements are possible.
3 participants
@AbhinavMir @CLAassistant @esdrubal