Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially fixes stack overflow when using recursive trait. #5515

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Partially fixes stack overflow when using recursive trait. #5515

wants to merge 1 commit into from

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Jan 24, 2024 •
edited

ReplaceDecls, CollectTypesMetadata, HashWithEngines now have a mechanism that interrupts recursive visiting.

The mechanism works by adding TypeIds or DeclIds to a HashMap or HashSet and no longer revisiting TypeIds or DeclIds on the passed collection.

This was necessary because in some cases while visiting a declaration we can go back to the beginning because of recursive DeclIds.

I suspect these changes will also be useful to #3018

This partially fixes #5504, which is still failing because we have yet to fix a recursion problem in the IR side of the compiler.

Description

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@esdrubal esdrubal mentioned this pull request Jan 24, 2024
Closed
@esdrubal esdrubal force-pushed the esdrubal/5504_fix_stackoverflow branch from 11e19f6 to 52ddd02 Compare January 24, 2024 15:10
@esdrubal esdrubal self-assigned this Jan 25, 2024
@esdrubal esdrubal force-pushed the esdrubal/5504_fix_stackoverflow branch from 52ddd02 to dfd86b1 Compare January 25, 2024 12:36
@esdrubal
Partially fixes stack overflow when using recursive trait.
dfd86b1 
ReplaceDecls, CollectTypesMetadata, HashWithEngines now have a mechanism that interrupts recursive visiting.

The mechanism works by adding TypeIds or DeclIds to a HashMap or HashSet and no longer visiting TypeIds or DeclIds on the passed collection.

This was necessary because in some cases while visiting a declaration we can go back to the beginning because of recursive DeclIds.

I suspect these changes will also be useful to #3018

This partially fixes #5504, which is still failing because we have yet to fix a recursion problem in the IR side of the compiler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@esdrubal esdrubal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite recursion (stack overflow) calling trait function on tuples
1 participant
@esdrubal