Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable scrolling in menus #301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saladinalep
Copy link

ref #95

@saladinalep
Copy link
Author

This is what I have so far.
What do you think?

@FrodeSolheim
Copy link
Owner

Hi, I did not notice this pull request until now! As a first draft, the scrolling looks fine (it should probably use constants to define the max visible items etc, but that's details. And later, animating the scrolling menu would be nice of course).

The main problem with your interest in save states is that right now, the number of save states is somewhat static due to how events are used to trigger loading/saving state. So, that whole bit also needs a rework. But for floppy list scrolling, this code could be useful sooner :)

@saladinalep
Copy link
Author

As a first draft, the scrolling looks fine (it should probably use constants to define the max visible items etc, but that's details. And later, animating the scrolling menu would be nice of course).

That's great!
I was contemplating the use of fsemu_util_spring_t to animate the scrolling. If it proves straightforward, I will include it in this PR.

the number of save states is somewhat static due to how events are used to trigger loading/saving state. So, that whole bit also needs a rework

Right. This will probably be my next little project :)

@saladinalep saladinalep marked this pull request as ready for review May 27, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants