Fixes for ACTION_EXAMINE_ALL and bsdsocket.library #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fail Fixed bsdsocket FIOSETOWN and FIOGETDOWN implemented backwards Fixed bsdsocket select - would corrupt caller's memory if < 33 fds selected
FrodeSolheim
requested changes
Feb 17, 2021
| if (!action_examine_all_do(ctx, unit, lock, eak, exalldata, exalldatasize, type, control)) | ||
| goto fail; | ||
| if (!action_examine_all_do(ctx, unit, lock, eak, exalldata, exalldatasize, type, control)) { | ||
| if (get_long (control + 0) == 0) |
There was a problem hiding this comment.
Could you explain a bit what's going on here (what the problem was and how this fixes it)? I'm not all that familiar with this code.
(Also, I suspect trap_get_long should be used instead of get_long?)
|
I'm not entirely sure about the fixes for FIOSETOWN and FIOGETDOWN; they do look wrong, but the fix looks wrong as well. I'm trying to find some proof of what they should be so I looked into the AmiTCP header files https://aminet.net/package/comm/net/AmiTCP-api-30b2. See linked issue #291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed ACTION_EXAMINE_ALL on FS-UAE root directory; last Exall() would fail
Fixed bsdsocket FIOSETOWN and FIOGETDOWN implemented backwards
Fixed bsdsocket select - would corrupt caller's memory if < 33 fds selected