Added white hex outline on hovering round counter. #2491
+20
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@dheerajd5 Heya! By "white outline" I didn't mean a new white hexagon (they tend to get edges overlapped at times), but css text effect for the letter-number coordinate, kinda like in this tut over here -> https://kinsta.com/blog/css-text-outline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #2240
Note:
As of now I am calling the
displayVisualState()function everytime for each hex in the grid, everytimeshowGrid()is called.I didn't notice much of a performance difference but I've put the results in the comments related to this issue.
This is what it looks like after adding the white hex.
