qol(sword-slitter): Added a 1 second delay before the second sword slitter #2489
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Good idea, we could have it as "Bounty Hunter used Sword Slitter twice". |
|
Tested and something odd seems to happen if Bounty Hunter kills target unit with the first hit: there's camera shake after 1s; so obviously, shake should happen on first hit only and no more shake after 1s. |
JoelFernandes09
force-pushed
the
qol/sword-slitter
branch
from
fa6fc2e
to
ca1d81d
Compare
|
@DreadKnight Should be good to go now! Added a target dead check in so the second hit is only trigger if the target is alive. |
|
@JoelFernandes09 Did more testing. Found one more issue, if Bounty Hunter kills the target using the second hit, a tooltip "Canceled" shows up pointlessly. That tooltip is used when toggling an ability off in various ways, never after abilities used. |
|
@DreadKnight Gotcha, will look into this |
|
@JoelFernandes09 Heya! Any progress with this? Eventually PRs go stale and get closed... |
|
Hey there! My apologies. I'll take a look at this & push the fix tomorrow itself. @DreadKnight |
JoelFernandes09
force-pushed
the
qol/sword-slitter
branch
from
a6f2712
to
58ca637
Compare
|
@DreadKnight Apologies for such a delay here. Should be good now! |
|
@JoelFernandes09 I've tested this and second attack that would kill the target doesn't happen at all. Needs more work... |
|
@JoelFernandes09 Heya! Can you poke at this so we can finish with it before it goes stale? |
After the delay the enemy takes damage along with a camera shake. Do we wanna add a game log here as well? Something like, "Bounty Hunter used a bonus Sword Slitter"?
Closes #2199