Revert Electron to 29.3.3 #5098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f661956.
github-actions
bot
added
PR: dependencies
auto-merge was automatically disabled
May 11, 2024 13:14
Pull request was closed
github-actions
bot
removed
the
PR: waiting for review
This reverts commit f336215.
jasonhenriquez
changed the title
github-actions
bot
added
the
PR: waiting for review
|
This should probably be the last PR to be merged before release. Lets focus on the few PR's that needs to be addressed so we can release. Lets hope Electron fixes their mess in the meantime. |
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
jasonhenriquez
changed the title
…at/revert-electron-30
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
jasonhenriquez
changed the title
|
Closed in favor of #5137. |
auto-merge was automatically disabled
May 20, 2024 14:30
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert Electron to 29.3.3
Pull Request Type
Related issue
#5054, #5055
Description
Reverts Electron version to prevent issues for what seems to be a good deal of Linux users. Many distros need the argument
--ozone-platform-hint=autoto be able to run correctly (e.g., most Linux systems running Wayland as the display system), some distros are blowing up when that argument is passed in (e.g., Ubuntu), and some installs can't have this argument applied programmatically when the default executable is run (e.g., Linux portable, Linux.7z).The immediate course of action that the FreeTube core contributor team discussed in our Matrix channel is to revert the Electron 30 upgrade, test the next major Electron versions to see if the issue is resolved, and if no fix is made, we will upgrade to the latest Electron version and figure out a solution.
Edit 2024-05-13: changed to 29.3.3 from prior 29.3.0 and revalidated.
Testing
Desktop