New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves quick bookmark UX #5082
Improves quick bookmark UX #5082
Conversation
aacadde
to
0d08002
Compare
Aside from the addition of a deletion prompt, I contend that this is a worse UX than #5058 for the reasons I laid out in our discussion on that PR. I will let the other developers read both threads and speak to make the determination because I just don't think we see eye-to-eye enough on UX design for our dialogue to continue to be productive past a certain point (as evidenced by you creating this PR rather than continuing the discussion where it left off, such that you seem to be inviting this scenario). |
I don't consider this as complete yet but at the same time without the prompt in #5058 I don't consider that as complete solution as well |
f4767cf
to
c90fc51
Compare
Prompt added |
Just to be clear with this comment I'm not taking sides on which approach is better. If you really want the prompt, please find a way to implement it that doesn't involve duplicating 90% of the add to playlist prompt code, e.g. with a shared component or even using the same prompt for both. |
@absidue |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@PikachuEXE this can be closed now right? |
Pull Request Type
Related issue
Closes #5051
Description
Look at commits in case this list becomes outdated
Disable deleting quick bookmark playlist target (Prevent >1 dangerous action performed with one user action)Screenshots
Testing
Update quick bookmark icons
Disable quick bookmark now requires a confirmation
Prompt user to select a new target when quick bookmark playlist target deleted
Disable deleting quick bookmark playlist targetUpdate user playlists view to allow updating/disabling quick bookmark & see current target
Allow user to attempt quick bookmark without target set
Desktop
Additional context