Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves quick bookmark UX #5082

Conversation

PikachuEXE
Copy link
Collaborator

@PikachuEXE PikachuEXE commented May 7, 2024

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #5051

Description

Look at commits in case this list becomes outdated

  • Update quick bookmark icons (changes from Always have quick bookmark set #5058)
  • Disable quick bookmark now requires a confirmation
  • Prompt user to select a new target when quick bookmark playlist target deleted
    Disable deleting quick bookmark playlist target (Prevent >1 dangerous action performed with one user action)
  • Update user playlists view to allow updating/disabling quick bookmark & see current target
  • Allow user to attempt quick bookmark without target set (new window to save progress, maybe should be same window? no idea)

Screenshots

Testing

Update quick bookmark icons
image
image

Disable quick bookmark now requires a confirmation
image

Prompt user to select a new target when quick bookmark playlist target deleted
image

Disable deleting quick bookmark playlist target
image

Update user playlists view to allow updating/disabling quick bookmark & see current target
image

Allow user to attempt quick bookmark without target set
image

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@PikachuEXE PikachuEXE force-pushed the feature/quick-bookmark/improve-ux branch from aacadde to 0d08002 Compare May 7, 2024 01:56
@jasonhenriquez
Copy link
Collaborator

jasonhenriquez commented May 7, 2024

Aside from the addition of a deletion prompt, I contend that this is a worse UX than #5058 for the reasons I laid out in our discussion on that PR. I will let the other developers read both threads and speak to make the determination because I just don't think we see eye-to-eye enough on UX design for our dialogue to continue to be productive past a certain point (as evidenced by you creating this PR rather than continuing the discussion where it left off, such that you seem to be inviting this scenario).

@PikachuEXE
Copy link
Collaborator Author

  • Disable quick bookmark now requires a confirmation + Allow user to attempt quick bookmark without target set: I never like forcing user to set a target (and potentially making mistakes without knowing until too late)
    There is no prompt implemented to select (instead it redirect to user playlists page) as this is what I have written in just an hour for preview

  • Disable deleting quick bookmark playlist target: if the select bookmark target prompt implemented this would be reverted

  • Update user playlists view to allow updating/disabling quick bookmark & see current target: applicable even Always have quick bookmark set #5058 is picked over this PR, but necessary part of this PR

  • Allow user to attempt quick bookmark without target set: Again since there is no prompt implemented yet this is for preview

I don't consider this as complete yet but at the same time without the prompt in #5058 I don't consider that as complete solution as well

@PikachuEXE PikachuEXE force-pushed the feature/quick-bookmark/improve-ux branch from f4767cf to c90fc51 Compare May 8, 2024 02:14
@PikachuEXE
Copy link
Collaborator Author

Prompt added
Description & screenshots updated

@PikachuEXE PikachuEXE marked this pull request as ready for review May 8, 2024 02:23
@github-actions github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels May 8, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 8, 2024 02:23
@absidue
Copy link
Member

absidue commented May 8, 2024

Just to be clear with this comment I'm not taking sides on which approach is better.

If you really want the prompt, please find a way to implement it that doesn't involve duplicating 90% of the add to playlist prompt code, e.g. with a shared component or even using the same prompt for both.

@PikachuEXE
Copy link
Collaborator Author

@absidue
Done
Not much experience in making shared component let me know what's wrong/left

@PikachuEXE PikachuEXE mentioned this pull request May 15, 2024
1 task
@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels May 20, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@efb4f5ff-1298-471a-8973-3d47447115dc

@PikachuEXE this can be closed now right?

@PikachuEXE PikachuEXE closed this May 20, 2024
auto-merge was automatically disabled May 20, 2024 10:26

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Always have a quick bookmark playlist set if possible
4 participants