New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: Migrate video player from video.js to shaka-player #4978
base: development
Are you sure you want to change the base?
Conversation
Relevant Invidious pull requests:
|
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Bugs found :) VirtualBoxVM_rSYCV6aiZM.mp4VirtualBoxVM_oANe1ccYRQ.mp4 |
This comment was marked as outdated.
This comment was marked as outdated.
I unfortunately can't solve the second one properly, unless we want to add an extra if on every second line in that file. The problem is that you are navigating too quickly, so the player component is getting destroyed in the middle of the asynchronous setup and as the setup is asynchronous it means that every single line could cause an error. |
This comment was marked as outdated.
This comment was marked as outdated.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
DRAFT: Migrate video player from video.js to shaka-player
Pull Request Type
Related issue
Description
After almost a years worth of work, here is the shaka-player migration.
Significant improvements and new features
et
(eesti keel), Basqueeu
(Euskera), Galiciangl
(galego) and Icelandicis
(Íslenska), for those languages it will use English (US) instead.ANDROID_TESTSUITE
client that Invidious uses, claims that all video streams use normal rectangular projection, so we don't have a way to identify VR videos through Invidious).Significant bug fixes
Missing/Removed features
Known issues
Screenshots
DASH
DASH with controls faded away
DASH in full screen mode
DASH in full window mode
DASH stats
Audio only with seek bar thumbnails and stats visible
Audio only with quality selector visible
Live DASH at live edge
Live DASH seeked back a few hours
Live audio only with subtitles
DASH with a vertical video/short
Audio only with a vertical video/short and the FreeTube locale preference set to French
Mobile audio only with the the overflow menu closed
Mobile audio only with the overflow menu open
Mobile DASH with the overflow menu open on a video with subtitles and multiple audio languages
VR video that uses equirectangular projection
Testing
Desktop