New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[client,sdl] Always disable decorations in multimon session #9957
base: master
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
39ffdbb
to
eb8b75c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
eb8b75c
to
64947a6
Compare
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, you missed a case ;)
there is the exit fullscreen key combination, then it makes sense for multimonitor sessions to have decorations.
Would it be sufficient to handle this case by updating the borders when the fullscreen state changes? Also, is it strictly necessary that the borders be updated for all window events? If not it may simplify things to move this code to |
This pull request modifies the code responsible for enabling/disabling borders on FreeRDP windows to consider whether the current session is multimonitor. IMO it doesn't really make sense for a multimonitor session to have borders, and removing the effective requirement that window decorations be explicitly disabled in this case makes for a nicer experience.
Additionally, this code was causing my graphics driver to sometimes hang when initially opening the windows, I would assume due to the combination of
SDL_WINDOW_BORDERLESS
andSDL_SetWindowBordered(SDL_TRUE)
. As far as I can tell this is a bug in KWin 6, but removing this trigger is also nice.