Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server channel event #9606

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Server channel event #9606

wants to merge 3 commits into from

Conversation

akallabeth
Copy link
Member

  • Remove timed wait after WTSQuerySessionInformationA before WTSVirtualChannelOpenEx (looks like some leftover from really long ago, anyone has a clue why that was added?)
  • Do some cleanups / fixes in server.c core API
  • Replace timed WaitForMultipleObjects with INFINITE (if there are issues we better fix them properly instead of using polling)

@akallabeth akallabeth added this to the 3.0.0 milestone Dec 5, 2023
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10819/

@akallabeth akallabeth modified the milestones: 3.0.0, next-3.0 Dec 5, 2023
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10820/

pnowack
pnowack requested changes Dec 5, 2023
View reviewed changes
Copy link
Member

@pnowack pnowack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a bug: The audin server does not open anymore with this PR. g-r-d waits endlessly on the response for the AUDIO_INPUT DVC, but does not get an answer (and thus shuts that DVC down due to lack of response).
If I don't apply this PR here, then this bug does not happen

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10823/

@akallabeth akallabeth modified the milestones: next-3.0, 3.0.0 Dec 6, 2023
@akallabeth akallabeth marked this pull request as ready for review December 6, 2023 09:20
@akallabeth
Copy link
Member Author

@pnowack ok, removed the offending commit, but the rest I´ve kept.

@akallabeth akallabeth modified the milestones: 3.0.0, next Dec 6, 2023
@akallabeth akallabeth marked this pull request as draft December 6, 2023 10:51
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/10829/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnowack pnowack pnowack requested changes

@hardening hardening Awaiting requested review from hardening

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akallabeth @freerdp-bot @pnowack